Many warnings during compile time

[olgood@…]

MinGW 4.7.2

gcc.compile.c++ bin.v2\libs\thread\build\gcc-mingw-4.7.2\release\link-static\threading-multi\win32\thread.o
In file included from ./boost/thread/shared_mutex.hpp:18:0,
                 from ./boost/thread/detail/thread_group.hpp:9,
                 from ./boost/thread/thread.hpp:24,
                 from libs\thread\src\win32\thread.cpp:15:
./boost/thread/win32/shared_mutex.hpp: In constructor 'boost::shared_mutex::shared_mutex()':
./boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member 'boost::shared_mutex::state_data::shared_waiting' [-Wmissing
-field-initializers]
./boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member 'boost::shared_mutex::state_data::exclusive' [-Wmissing-fiel
d-initializers]
./boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member 'boost::shared_mutex::state_data::upgrade' [-Wmissing-field-
initializers]
./boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member 'boost::shared_mutex::state_data::exclusive_waiting' [-Wmiss
ing-field-initializers]
./boost/thread/win32/shared_mutex.hpp:98:33: warning: missing initializer for member 'boost::shared_mutex::state_data::exclusive_waiting_blocked'
 [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp: In static member function 'static unsigned int boost::thread::hardware_concurrency()':
libs\thread\src\win32\thread.cpp:390:30: warning: missing initializer for member '_SYSTEM_INFO::dwPageSize' [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp:390:30: warning: missing initializer for member '_SYSTEM_INFO::lpMinimumApplicationAddress' [-Wmissing-field-ini
tializers]
libs\thread\src\win32\thread.cpp:390:30: warning: missing initializer for member '_SYSTEM_INFO::lpMaximumApplicationAddress' [-Wmissing-field-ini
tializers]
libs\thread\src\win32\thread.cpp:390:30: warning: missing initializer for member '_SYSTEM_INFO::dwActiveProcessorMask' [-Wmissing-field-initializ
ers]
libs\thread\src\win32\thread.cpp:390:30: warning: missing initializer for member '_SYSTEM_INFO::dwNumberOfProcessors' [-Wmissing-field-initialize
rs]
libs\thread\src\win32\thread.cpp:390:30: warning: missing initializer for member '_SYSTEM_INFO::dwProcessorType' [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp:390:30: warning: missing initializer for member '_SYSTEM_INFO::dwAllocationGranularity' [-Wmissing-field-initial
izers]
libs\thread\src\win32\thread.cpp:390:30: warning: missing initializer for member '_SYSTEM_INFO::wProcessorLevel' [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp:390:30: warning: missing initializer for member '_SYSTEM_INFO::wProcessorRevision' [-Wmissing-field-initializers
]
libs\thread\src\win32\thread.cpp: In function 'LARGE_INTEGER boost::this_thread::{anonymous}::get_due_time(const boost::detail::timeout&)':
libs\thread\src\win32\thread.cpp:412:44: warning: missing initializer for member '_LARGE_INTEGER::<anonymous struct>::HighPart' [-Wmissing-field-
initializers]
libs\thread\src\win32\thread.cpp:426:53: warning: missing initializer for member '_SYSTEMTIME::wMonth' [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp:426:53: warning: missing initializer for member '_SYSTEMTIME::wDayOfWeek' [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp:426:53: warning: missing initializer for member '_SYSTEMTIME::wDay' [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp:426:53: warning: missing initializer for member '_SYSTEMTIME::wHour' [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp:426:53: warning: missing initializer for member '_SYSTEMTIME::wMinute' [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp:426:53: warning: missing initializer for member '_SYSTEMTIME::wSecond' [-Wmissing-field-initializers]
libs\thread\src\win32\thread.cpp:426:53: warning: missing initializer for member '_SYSTEMTIME::wMilliseconds' [-Wmissing-field-initializers]
In file included from ./boost/thread/shared_mutex.hpp:18:0,
                 from ./boost/thread/detail/thread_group.hpp:9,
                 from ./boost/thread/thread.hpp:24,
                 from libs\thread\src\win32\thread.cpp:15:
./boost/thread/win32/shared_mutex.hpp: In instantiation of 'T boost::shared_mutex::interlocked_compare_exchange(T*, T, T) [with T = boost::shared
_mutex::state_data]':
./boost/thread/win32/shared_mutex.hpp:124:103:   required from here
./boost/thread/win32/shared_mutex.hpp:52:99: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
./boost/thread/win32/shared_mutex.hpp:52:99: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
./boost/thread/win32/shared_mutex.hpp:53:52: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
./boost/thread/win32/shared_mutex.hpp:53:52: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

[viboes]

Do you have a patch?

[viboes]

Please, could you tell me if the warnings appear when you define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN?

[anonymous]

Replying to viboes:

Please, could you tell me if the warnings appear when you define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN?

I eliminated Boost form my project and am unable to reproduce the warnings quickly. It will take a several days. Sorry. Please wait. Or may be somebody other will try to reproduce. As far as I remember they happen during Boost build.

[barnabe.faliu@…]

Warnings still appears even if i define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN

[olgood@…]

Replying to barnabe.faliu@…:

Warnings still appears even if i define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN

Could you please provide me a command line which allow me quickly to reproduce the issue on my set too? Thanks.

[Barnabé Faliu <barnabe.faliu@…>]

#include <iostream>
#include <boost/thread/thread.hpp>

#define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN
using namespace std;



int main() {
	cout << "!!!Hello World!!!" << endl; // prints !!!Hello World!!!
	return 0;
}

This is the only lines in my file. I included C:\Boost\boost_1_52_0, added this library path : C:\Boost\boost_1_52_0\lib and thoose libraries : boost_system-mgw47-1_52 boost_thread-mgw47-mt-sd-1_52

[olgood@…]

Thanks.

I remembered that my program was even shorter - just #include <boost/thread/threads.hpp> and main(int,char){}

This gave warnings and one error (I asked about this on StackOverflow).

And I remembered I've just fixed that warnings for my Boost's sources without backup. So, now I'm unable to reproduce the issue because do not have sources.

Hope, now you'll help Boost guys to fix the issue.

Replying to Barnabé Faliu <barnabe.faliu@…>:

#include <iostream>
#include <boost/thread/thread.hpp>

#define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN
using namespace std;



int main() {
	cout << "!!!Hello World!!!" << endl; // prints !!!Hello World!!!
	return 0;
}

This is the only lines in my file. I included C:\Boost\boost_1_52_0, added this library path : C:\Boost\boost_1_52_0\lib and thoose libraries : boost_system-mgw47-1_52 boost_thread-mgw47-mt-sd-1_52

[anonymous]

But hey! Just noted: seems you have to put define before include. Isn't it?

Replying to Barnabé Faliu <barnabe.faliu@…>:

#include <iostream>
#include <boost/thread/thread.hpp>

#define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN
using namespace std;



int main() {
	cout << "!!!Hello World!!!" << endl; // prints !!!Hello World!!!
	return 0;
}

This is the only lines in my file. I included C:\Boost\boost_1_52_0, added this library path : C:\Boost\boost_1_52_0\lib and thoose libraries : boost_system-mgw47-1_52 boost_thread-mgw47-mt-sd-1_52

[Barnabé Faliu <barnabe.faliu@…>]

Replying to anonymous:

Problem solved ! Thank you very much

But hey! Just noted: seems you have to put define before include. Isn't it?

Replying to Barnabé Faliu <barnabe.faliu@…>:

#include <iostream>
#include <boost/thread/thread.hpp>

#define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN
using namespace std;



int main() {
	cout << "!!!Hello World!!!" << endl; // prints !!!Hello World!!!
	return 0;
}

This is the only lines in my file. I included C:\Boost\boost_1_52_0, added this library path : C:\Boost\boost_1_52_0\lib and thoose libraries : boost_system-mgw47-1_52 boost_thread-mgw47-mt-sd-1_52

[olgood@…]

Therefore, the answer for viboes' question regarding the flag BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN is positive: yes the flag eliminates that warnings.

Replying to Barnabé Faliu <barnabe.faliu@…>:

Replying to anonymous:

Problem solved ! Thank you very much

But hey! Just noted: seems you have to put define before include. Isn't it?

Replying to Barnabé Faliu <barnabe.faliu@…>:

#include <iostream>
#include <boost/thread/thread.hpp>

#define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN
using namespace std;



int main() {
	cout << "!!!Hello World!!!" << endl; // prints !!!Hello World!!!
	return 0;
}

This is the only lines in my file. I included C:\Boost\boost_1_52_0, added this library path : C:\Boost\boost_1_52_0\lib and thoose libraries : boost_system-mgw47-1_52 boost_thread-mgw47-mt-sd-1_52

[viboes]

On 1.54, I would define BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN by default as I don't see any regression on it.

Unfortunately I don't think this merits the change in 1.53 given the advanced state of the release.

Could I close this ticket then?

[Barnabé Faliu <barnabe.faliu@…>]

Yes you can close it ! Thanks again for your help

[viboes]

Conclusion: I won't fix as an acceptable alternative exists.