Add add_ref param to intrusive_ptr::reset

[Bruno Martinez Aguerre <bruno.uy@…>]

intrusive_ptr::reset should have an optional bool add_ref=true parameter just as the intrusive_ptr constructor has. Currently you can call the constructor and assign, but this forces you to mention the template pointer type.

[bruno.uy@…]

Actually I think I prefer

template<class T> intrusive_ptr<T> take_ptr(T* t) {

return intrusive_ptr<T>(t, false);

}

from ​http://www.gamedev.net/topic/556405-should-i-be-using-ccomptr--boostshare_ptr-or-boostintrusive_ptr-for-com/#entry4573797

take_ptr is like a hypothetical make_intrusive, which only make sense for the add_ref=false case because raw T* is already convertible to intrusive_ptr<T> in the add_ref=true case. take_ptr as a separate function is also clearer than a false argument to the constructor, and with r-values, as efficient as reset(ptr, false) would be. If I could travel back in time I would suggest take_ptr as a friend function and getting rid of the add_ref parameter altogether.

[Peter Dimov]

Done in ​https://github.com/boostorg/smart_ptr/commit/4de3f36839bfaf800e1f875d2f8e07412f9909bf