Opened 10 years ago

Closed 10 years ago

#7880 closed Bugs (wontfix)

unused parameter warnings

Reported by: alex@… Owned by:
Milestone: To Be Determined Component: None
Version: Boost 1.52.0 Severity: Optimization
Keywords: Cc:

Description

There's a few methods which produce 'unused parameter' warnings and prevent having warning be treated as errors.

I'm attaching a patch that fixes the ones that I've found.

Attachments (1)

boost-unused-param.patch (3.7 KB ) - added by anonymous 10 years ago.

Download all attachments as: .zip

Change History (4)

by anonymous, 10 years ago

Attachment: boost-unused-param.patch added

comment:1 by Marshall Clow, 10 years ago

Two comments:

1) You should create two tickets, one for spirit and one for tokenizer, and assign them to the maintainers of those libraries. That will help bring them to their attention. Bugs submitted against "boost" (no component) are likely to be missed.

2) A better way to silence these warnings is to "not name" the parameters.

Instead of:

grammar_helper_list& operator=(grammar_helper_list const& x) 
	{   // Does _not_ copy the helpers member ! 
		(void) x; 
		return *this; 
	} 

You should write:

grammar_helper_list& operator=(grammar_helper_list const&) 
	{   // Does _not_ copy the helpers member ! 
		return *this; 
	} 

comment:2 by alex@…, 10 years ago

Both comments make sense. I will report two separate bugs in their respective projects and modify my patch according to the suggestion #2 above. Thanks!

comment:3 by Marshall Clow, 10 years ago

Resolution: wontfix
Status: newclosed

Thanks. I'm going to close this bug, and wait for the next ones.

Note: See TracTickets for help on using tickets.