Opened 16 years ago

Closed 13 years ago

#827 closed Patches (fixed)

Unused variable in format date parser

Reported by: alexis_wilke Owned by: az_sw_dude
Milestone: Component: date_time
Version: None Severity: Problem
Keywords: Cc:

Description (last modified by Marshall Clow) 

May sound silly, but an unused variable could represent a bug. Thus, Coverity found it and signaled it. It would be nice to have it removed to avoid that error in the future.

The variable seems to be a left over from other parsing functions which do make use of it.

Change History (3)

comment:1 by alexis_wilke, 16 years ago 

Logged In: YES 
user_id=554061
Originator: YES

Hi guys,

I also noticed that by removing the code I removed, the current_char variable is actually unused.

I uploaded a newer patch with all the fixes.

Alexis Wilke
File Added: format_date_parser.patch

comment:2 by Marshall Clow, 15 years ago

Component: None → date_time
Description: modified (diff)
Severity: → Problem

comment:3 by Andrey Semashev, 13 years ago

Resolution: None → fixed
Status: assigned → closed

It appears that it has already been addressed. I didn't find any unused current_char or use_current_char variables in the sources.

Note: See TracTickets for help on using tickets.