Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8478 closed Patches (fixed)

Make Boost.wave compatible with Clang's -Wimplicit-fallthrough diagnostic.

Reported by: Alexander Kornienko <alexfh@…> Owned by: Hartmut Kaiser
Milestone: To Be Determined Component: wave
Version: Boost Development Trunk Severity: Problem
Keywords: Cc: John Maddock

Description

Patch that inserts BOOST_FALLTHROUGH to annotate fallthrough between switch cases. Ticket with discussion of BOOST_FALLTHROUGH: #8408

Attachments (1)

wave.patch (1.5 KB ) - added by Alexander Kornienko <alexfh@…> 10 years ago.

Download all attachments as: .zip

Change History (3)

by Alexander Kornienko <alexfh@…>, 10 years ago

Attachment: wave.patch added

comment:1 by Hartmut Kaiser, 10 years ago

Resolution: fixed
Status: newclosed

(In [84012]) Fixed #8478: Make Boost.wave compatible with Clang's -Wimplicit-fallthrough diagnostic.

comment:2 by Alexander Kornienko <alexfh@…>, 10 years ago

The last case label doesn't require BOOST_FALLTHROUGH annotation after it. Clang's diagnostic doesn't care about falling through via next loop iteration. Please remove BOOST_FALLTHROUGH after case 1:

case 1: *b = c; ++b; BOOST_FALLTHROUGH;

Note: See TracTickets for help on using tickets.