Opened 9 years ago

Closed 9 years ago

#8690 closed Patches (fixed)

duration_units_default - lost return types constness in overridden methods

Reported by: tmmikolajczyk@… Owned by: viboes
Milestone: Boost 1.54.0 Component: chrono
Version: Boost 1.53.0 Severity: Problem
Keywords: Cc:

Description

When implementing custom chrono duration units by deriving from duration_units_default<> I noticed the "get_valid_units_start" and "get_valid_units_end" is declared to return mutable string_type pointer however the base class (duration_units<>) declares them as immutable. The attached patch has been generated with the "git diff --no-prefix" command (I have boost svn repo cloned with the git-svn tool).

Attachments (1)

duration_unit_return_type.patch​ (825 bytes ) - added by tmmikolajczyk@… 9 years ago.

Download all attachments as: .zip

Change History (6)

by tmmikolajczyk@…, 9 years ago

Attachment: duration_unit_return_type.patch​ added

comment:1 by tmmikolajczyk@…, 9 years ago

It concerns the 1.53 version and the latest trunk as well.

comment:2 by viboes, 9 years ago

Milestone: To Be Determined → Boost 1.54.0
Status: new → assigned

comment:3 by viboes, 9 years ago

Thanks for catching this issue. I will try to fix it for 1.54.

Last edited 9 years ago by viboes (previous) (diff)

comment:4 by viboes, 9 years ago

Committed revision [84751].

comment:5 by viboes, 9 years ago

Resolution: → fixed
Status: assigned → closed

(In [84767]) Chrono: fix #8690.

Note: See TracTickets for help on using tickets.