Opened 9 years ago
Closed 9 years ago
#8691 closed Bugs (fixed)
iostate is not checked after scan_keyword call
| Reported by: | Owned by: | viboes | |
|---|---|---|---|
| Milestone: | Boost 1.54.0 | Component: | chrono |
| Version: | Boost Development Trunk | Severity: | Problem |
| Keywords: | Cc: |
Description
Implementation of the duration_get::do_get_n_d_valid_unit and duration_get::do_get_valid_unit methods calls chrono_detail::scan_keyword and then unconditionally calls the facet.match_n_d_valid_unit and facet.match_valid_unit methods appropriately, no matter what is the value of the iostate flag. IMO, the function should just return value "i" if iostate is not good after the scan_keyword call. The proposed change is attached as a patch. The patch fixes also typos in doxygen comments of those functions.
Attachments (1)
Change History (4)
by , 9 years ago
| Attachment: | chrono_duration_get_bug_8691.patch added |
|---|
comment:1 by , 9 years ago
| Milestone: | To Be Determined → Boost 1.54.0 |
|---|---|
| Status: | new → assigned |
comment:3 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Thanks for catching this. I'll try to fix it for 1.54.