Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#8754 closed Patches (fixed)

Boost.Build needs support for the VS2013 Preview toolset (18.00.20617.1)

Reported by: Lars Viklund <zao@…> Owned by: Jürgen Hunold
Milestone: To Be Determined Component: build
Version: Boost 1.54.0 Severity: Problem
Keywords: Cc:

Description

Visual Studio 2013 Preview is out and claims to be 12.0. I copy-pasted everything related to 11.0 to refer to 12.0 and it Works On My Machine, see attached patch.

Attachments (2)

0002-Boost.Build-copy-paste-MSVC-11.0-to-12.0.patch (4.3 KB ) - added by Lars Viklund <zao@…> 9 years ago.
0001-Boost.Build-copy-paste-MSVC-11.0-to-12.0-add-vc12-to.patch (7.5 KB ) - added by Lars Viklund <zao@…> 9 years ago.
Amended patch, introduces vc12 toolset

Download all attachments as: .zip

Change History (7)

by Lars Viklund <zao@…>, 9 years ago

comment:1 by Jürgen Hunold, 9 years ago

Patch looks good. Can you also try to get engine\build.bat patched? This will allow building b2 with msvc-12.0, too. Take a look if %VS120COMNTOOLS% is defined, please.

comment:2 by Lars Viklund <zao@…>, 9 years ago

Environment in a fresh cmd.exe contains:

VS110COMNTOOLS=C:\Program Files\Microsoft Visual Studio 11.0\Common7\Tools\
VS120COMNTOOLS=C:\Program Files\Microsoft Visual Studio 12.0\Common7\Tools\

I've also verified that the registry key used elsewhere exists. As a side note, I was informed that I'd forgotten to make sure that the first tests in msvc.jam is an if and the rest are else if.

I've attached a more exhaustive patch, including fixes to build.bat, build.jam and the if-else chain in msvc.jam.

by Lars Viklund <zao@…>, 9 years ago

Amended patch, introduces vc12 toolset

comment:3 by Jürgen Hunold, 9 years ago

Owner: changed from Vladimir Prus to Jürgen Hunold

comment:4 by Jürgen Hunold, 9 years ago

Resolution: fixed
Status: newclosed

(In [84983]) Fix #8754: Add support for upcoming msvc-12.0

Thanks to Lars Viklund for the patch

comment:5 by Jürgen Hunold, 9 years ago

(In [85166]) Merge 84982,84983 from trunk. Fix #8754.

------------------------------------------------------------------------ r84982 | jhunold | 2013-07-08 15:11:49 +0200 (Mo, 08 Jul 2013) | 1 line

Fix: correct elif chain ------------------------------------------------------------------------ r84983 | jhunold | 2013-07-08 15:12:18 +0200 (Mo, 08 Jul 2013) | 3 lines

Fix #8754: Add support for upcoming msvc-12.0

Thanks to Lars Viklund for the patch ------------------------------------------------------------------------

Note: See TracTickets for help on using tickets.