#8757 closed Patches (invalid)
Boost.Serialization lacks algorithm header include for std::min
Reported by: | Owned by: | Robert Ramey | |
---|---|---|---|
Milestone: | To Be Determined | Component: | serialization |
Version: | Boost 1.54.0 | Severity: | Problem |
Keywords: | Cc: |
Description
The <algorithm>
header providing std::min
is not included in boost/archive/iterators/transform_width.hpp
, this breaks on Visual Studio 2013 Preview due to library changes.
Attachments (1)
Change History (9)
by , 9 years ago
Attachment: | 0005-Boost.S11n-include-missing-algorithm.patch added |
---|
comment:1 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
follow-up: 5 comment:2 by , 8 years ago
I tried building straight from Visual Studio 2012 Command Prompt, with included algorithm line, it still fails:
.\boost/archive/iterators/transform_width.hpp(29) : fatal error C1083: Cannot open include file: 'agorithm': No such file or directory
Is there a workaround for this?
comment:3 by , 8 years ago
I looked in the 1.55 release, and in the current git repo, and each of them had:
#include <algorithm> // std::min
for line 29.
comment:4 by , 8 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:5 by , 8 years ago
Replying to mwpowellhtx@…:
I tried building straight from Visual Studio 2012 Command Prompt, with included algorithm line, it still fails:
.\boost/archive/iterators/transform_width.hpp(29) : fatal error C1083: Cannot open include file: 'agorithm': No such file or directory
Is there a workaround for this?
Is that an accurate error message? If so, then I think the key is the name "agorithm" (which is different from "algorithm") in the error message.
comment:6 by , 8 years ago
Yes, it is exactly what I got when I downloaded 1.55 sources and attempted the full rebuild.
comment:7 by , 7 years ago
Resolution: | → invalid |
---|---|
Status: | reopened → closed |
I have no idea what to do about this. I've searched the whole source for "algorithm" and found nothing. I'm going to chalk it up to come VS2012 quirk
comment:8 by , 7 years ago
I think what the user is saying is that in the 1.55 release, there was a typo, where the file to include was misspelled. "agorithm"
Looking at the logs, it appears that this was fixed (at least on master) by this commit:
8af0e20b (Robert Ramey 2013-11-16)
There's nothing more to do here. We're not going to change the 1.55 release.
patch applied to trunk