libs/regex/src/fileiter.cpp: Spurious failure check

[Jeffrey Walton <noloader@…>]

Line 106:

hmap = CreateFileMapping(hfile, 0, PAGE_READONLY, 0, 0, 0);

if((hmap == INVALID_HANDLE_VALUE)

(hmap == NULL))

{

CloseHandle(hfile); hmap = 0; hfile = 0; std::runtime_error err("Unable to create file mapping."); boost::re_detail::raise_runtime_error(err);

}

According to MSDN (​http://msdn.microsoft.com/en-us/library/windows/desktop/aa366537%28v=vs.85%29.aspx), CreateFileMapping returns NULL on failure, and not INVALID_HANDLE_VALUE.

[John Maddock]

Is this a real issue? I guess in theory the extra check for INVALID_HANDLE_VALUE isn't required, but it certainly can't do any harm?