Opened 16 years ago
Closed 13 years ago
#900 closed Bugs (fixed)
graphml reader namespace handling is broken
| Reported by: | count0 | Owned by: | Jeremiah Willcock |
|---|---|---|---|
| Milestone: | Component: | graph | |
| Version: | None | Severity: | Problem |
| Keywords: | Cc: |
Description
I believe the modifications done in
http://boost.cvs.sourceforge.net/boost/boost/libs/graph/src/graphml.cpp?r1=1.1&r2=1.2
break xml namespace processing, since it will strip any namespace information from all tags (everything before "|"), not only those which,belong to the graphml namespace. So, tags belonging to other namespaces, such as "foo:node", will be wrongly parsed as graphml tags, eg. "node"...
I'm sending attached patches which revert to the old behavior and have two further modifications:
- Better expat error handling. It now informs the user where in the file a problem occured
- Reordering of tag processing for possible speed improvement ("node" is more frequent than "graph", so it should be tested first, etc)
I'm also sending slightly improved documentation and test case.
Attachments (6)
Change History (15)
comment:2 by , 16 years ago
Logged In: YES user_id=365386 Originator: YES File Added: reader_test.cc
comment:3 by , 16 years ago
Logged In: YES user_id=365386 Originator: YES File Added: reader-test.xml
comment:4 by , 16 years ago
Logged In: YES user_id=365386 Originator: YES File Added: read_graphml.rst
comment:5 by , 16 years ago
Logged In: YES user_id=365386 Originator: YES File Added: write_graphml.rst
comment:6 by , 13 years ago
| Severity: | → Showstopper |
|---|
I do not see any files anymore. It appears the parse error issue has been fixed; have the other issues?
comment:7 by , 13 years ago
| Severity: | Showstopper → Problem |
|---|
by , 13 years ago
| Attachment: | graphml.cpp.patch added |
|---|
by , 13 years ago
| Attachment: | graphml.hpp.patch added |
|---|
by , 13 years ago
| Attachment: | reader_test.cc added |
|---|
by , 13 years ago
| Attachment: | reader-test.xml added |
|---|
by , 13 years ago
| Attachment: | read_graphml.rst added |
|---|
by , 13 years ago
| Attachment: | write_graphml.rst added |
|---|
comment:8 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → new |
These are the files from the old tracker.
comment:9 by , 13 years ago
| Resolution: | None → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
