Opened 15 years ago

Closed 15 years ago

#906 closed Bugs (fixed)

Bug in Win32 implementation w/ static linking

Reported by: j_nilsson Owned by: Anthony Williams
Milestone: Boost 1.34.1 Component: threads
Version: None Severity: Showstopper
Keywords: Cc: witt@…

Description

[reposting this to the bug tracker]

Hi,

I believe I've found a bug in tss.cpp, for details please ref 
http://article.gmane.org/gmane.comp.lib.boost.user/26591 .

The immediate fix is straightforward, it just involves resetting the native tss value after deleting the pointed-to data at thread exit. Patch is attached to this message. The changes only affects the Win32 platform and I've run the supplied tests under libs/thread/test to verify that it doesn't break anything obvious.

As the bug involves dereferencing a dangling pointer and isn't detected most of the time, I'd really appreciate if the patch could be accepted as soon as 
possible. I'm awaiting Roland Schwartz to "bless" the patch. If he agrees, would it be possible to accept this for 1.34?

/ Johan

Attachments (1)

tss.cpp.patch (1.4 KB ) - added by Anthony Williams 15 years ago.
Patch for libs/thread/src/tss.cpp

Download all attachments as: .zip

Change History (6)

comment:1 by r.johan.nilsson@…, 15 years ago

The bug needs further fixes, as discussed later in the same thread:

http://thread.gmane.org/gmane.comp.lib.boost.devel/157790/focus=158472

comment:2 by Anthony Williams, 15 years ago

Owner: changed from glassfordm to Anthony Williams
Severity: Showstopper
Status: assignednew

comment:3 by Anthony Williams, 15 years ago

Status: newassigned

by Anthony Williams, 15 years ago

Attachment: tss.cpp.patch added

Patch for libs/thread/src/tss.cpp

comment:4 by Thomas Witt, 15 years ago

Cc: witt@… added
Milestone: Boost 1.34.1

comment:5 by Anthony Williams, 15 years ago

Resolution: Nonefixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.