select_on_container_copy_construction for scoped_allocator segfaults

[Markus Mathes <Markus.Mathes@…>]

using gcc 4.4.7 or 4.6.3 for linux the following code segfaults due to a problem with select_on_container_copy_construction

#include <memory>
#include <boost/container/scoped_allocator.hpp>
#include <boost/container/vector.hpp>


int main(int argc, char* argv[]) {
   typedef boost::container::scoped_allocator_adaptor<std::allocator<int> > Allocator;
   typedef boost::container::vector<int, Allocator> MyVector;

   MyVector test1;
   MyVector test2(test1);
};

[Markus Mathes <Markus.Mathes@…>]

The same code runs fine with boost 1.52.0

[Markus Mathes <Markus.Mathes@…>]

The inner_traits_type::select_on_container_copy_construction(this->inner_allocator()) statement in select_on_container_copy_construction causes an infinite recursion loop for a scoped allocator without any inner allocator type. (Inner allocator points back to outer) Somehow one has to distinguish the cases without and with inner allocator. In the latter case skipping the inner_traits_type::select_on_container_copy_construction part in the constructor call could be used to break the loop.

[Ion Gaztañaga]

Thanks for the report and the patch. I've modified it to pass the logic to the bass class, where an specialization for 0 inner alllocator can handle select_on_container_copy_construction a bit differently.

[Ion Gaztañaga]

(In [85537]) Fixes #9064