Opened 9 years ago

Last modified 8 years ago

#9068 new Patches

`parser_buf` like class moved to boost/detail/basic_pointerbuf.hpp

Reported by: Antony Polukhin Owned by: John Maddock
Milestone: To Be Determined Component: regex
Version: Boost Development Trunk Severity: Cosmetic
Keywords: Cc:

Description

Boost.LexicalCast uses slightly modifyed version of parser_buf from boost/regex/v4/cpp_regex_traits.hpp (see #8267).

In [85523] I've moved common code to the boost/detail/basic_pointerbuf.hpp and now boost/regex/v4/cpp_regex_traits.hpp can be updated to use the common code (see patch in attachment).

Attachments (1)

parser_buf.patch​ (3.6 KB ) - added by Antony Polukhin 9 years ago.
Patch to use boost/detail/basic_pointerbuf.hpp in cpp_regex_traits.hpp

Download all attachments as: .zip

Change History (5)

by Antony Polukhin, 9 years ago

Attachment: parser_buf.patch​ added

Patch to use boost/detail/basic_pointerbuf.hpp in cpp_regex_traits.hpp

comment:1 by John Maddock, 9 years ago

Thanks for the patch, I will apply this, but I think I need the new file to go into the master branch before I can do so.

Thanks, John.

comment:2 by John Maddock, 8 years ago

What happened to this file post-git?

comment:3 by Antony Polukhin, 8 years ago

I can see this file in ​lexical_cast/include/boost/detail. But it looks wrong to add dependency to LexicalCast for Regex.

Maybe we shall move basic_pointerbuf.hpp to Boost.Utility?

comment:4 by John Maddock, 8 years ago

I can see this file in lexical_cast/include/boost/detail. But it looks wrong to add dependency to LexicalCast? for Regex.

Looks like it reverted to your ownership post-convert to Git.

Maybe we shall move basic_pointerbuf.hpp to Boost.Utility?

If you're happy to do the work and document it etc, then that would be great. Otherwise we just leave things as they are I guess...

Note: See TracTickets for help on using tickets.