Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#9279 closed Bugs (fixed)

Lack of min/max under VC12/VS2013

Reported by: gongminmin@… Owned by: John Maddock
Milestone: To Be Determined Component: config
Version: Boost 1.55.0 Severity: Problem
Keywords: Cc:

Description

Missing min/max in boost/config/stdlib/dinkumware.hpp causes some libraries failed to build under vc12. The patch is in ticket #8750, ​https://svn.boost.org/trac/boost/attachment/ticket/8750/for_vs2013.patch.

Change History (5)

comment:1 by John Maddock, 9 years ago

Although I'm not necessarily against this patch - I'm a bit concerned about Boost.Config unconditionally including <algorithm>. If individual libraries are using functions like min/max without including that header, then they should be the ones patched IMO. This helps to keep Boost.Config's dependencies as small as possible.

comment:2 by gongminmin@…, 9 years ago

Yes. In my test, the min/max only affect the Boost.Serialization. So add 

#if defined(_MSC_VER) && (_MSC_VER >= 1800) 
#  include <algorithm> // for std::min and std::max 
#endif

to boost\archive\iterators\transform_width.hpp also fix this problem.

comment:3 by John Maddock, 9 years ago

(In [86394]) Refs #9279.

comment:4 by John Maddock, 9 years ago

Resolution: → fixed
Status: new → closed

Closing as Boost.Config is already patched for VC 2013.

comment:5 by John Maddock, 9 years ago

Update: serialization is also already patched to include <algorithm>.

Note: See TracTickets for help on using tickets.