Opened 9 years ago

Closed 9 years ago

#9371 closed Bugs (wontfix)

g++ 4.7 -Wshadow warnings need attention

Reported by: Tom Browder <tom.browder@…> Owned by: Jeremiah Willcock
Milestone: To Be Determined Component: graph
Version: Boost 1.55.0 Severity: Problem
Keywords: Cc:

Description

Following are warnings from g++ 4.7

boost/graph/detail/adjacency_list.hpp:2608:16: warning: declaration of 'tag' shadows a member of 'this' [-Wshadow]

boost/graph/detail/adjacency_list.hpp:2608:59: warning: declaration of 'tag' shadows a member of 'this' [-Wshadow]

boost/graph/graph_concepts.hpp:474:9: warning: declaration of 'g' shadows a member of 'this' [-Wshadow]

boost/graph/graph_concepts.hpp:501:9: warning: declaration of 'g' shadows a member of 'this' [-Wshadow]

boost/graph/graphviz.hpp:516:61: warning: declaration of 'dp' shadows a member of 'this' [-Wshadow]

boost/graph/graphviz.hpp:545:7: warning: declaration of 'dp' shadows a member of 'this' [-Wshadow]

boost/graph/graphviz.hpp:545:7: warning: declaration of 'node_id' shadows a member of 'this' [-Wshadow]

boost/graph/graphviz.hpp:585:9: warning: declaration of 'dp' shadows a member of 'this' [-Wshadow]

boost/graph/graphviz.hpp:585:9: warning: declaration of 'node_id' shadows a member of 'this' [-Wshadow]

boost/graph/graphviz.hpp:673:5: warning: declaration of 'errmsg' shadows a member of 'this' [-Wshadow]

boost/graph/named_graph.hpp:222:7: warning: declaration of 'extract' shadows a member of 'this' [-Wshadow]

boost/graph/named_graph.hpp:222:7: warning: declaration of 'graph' shadows a member of 'this' [-Wshadow]

boost/graph/named_graph.hpp:295:79: warning: declaration of 'vertex_constructor' shadows a member of 'this' [-Wshadow]

Change History (2)

comment:1 by Jeremiah Willcock, 9 years ago

(In [86680]) Changed some names to fix shadowing warnings; refs #9371

comment:2 by Jeremiah Willcock, 9 years ago

Resolution: wontfix
Status: newclosed

I fixed the ones that were about local variables; using constructor parameters with the same names as the members they initialize is a standard idiom in C++ so I won't change those.

Note: See TracTickets for help on using tickets.