Opened 9 years ago

Closed 9 years ago

#9376 closed Bugs (wontfix)

g++ 4.7 -Wshadow warnings need attention

Reported by: Tom Browder <tom.browder@…> Owned by: Douglas Gregor
Milestone: To Be Determined Component: property_map
Version: Boost 1.55.0 Severity: Problem
Keywords: Cc:

Description

Following are warnings from g++ 4.7

boost/property_map/property_map.hpp:634:54: warning: declaration of 'pm' shadows a member of 'this' [-Wshadow]

boost/property_map/vector_property_map.hpp:33:9: warning: declaration of 'index' shadows a member of 'this' [-Wshadow]

boost/property_map/vector_property_map.hpp:38:9: warning: declaration of 'index' shadows a member of 'this' [-Wshadow]

boost/property_map/dynamic_property_map.hpp:80:51: warning: declaration of 'property' shadows a member of 'this' [-Wshadow]

boost/property_map/dynamic_property_map.hpp:95:52: warning: declaration of 'property' shadows a member of 'this' [-Wshadow]

boost/property_map/dynamic_property_map.hpp:149:14: warning: declaration of 'key' shadows a member of 'this' [-Wshadow]

boost/property_map/dynamic_property_map.hpp:170:5: warning: declaration of 'property_map_' shadows a member of 'this' [-Wshadow]

boost/property_map/dynamic_property_map.hpp:173:3: warning: declaration of 'key' shadows a member of 'this' [-Wshadow]

boost/property_map/dynamic_property_map.hpp:178:3: warning: declaration of 'key' shadows a member of 'this' [-Wshadow]

Change History (2)

comment:1 by Jeremiah Willcock, 9 years ago

(In [86681]) Changed some names to fix shadowing warnings; refs #9376

comment:2 by Jeremiah Willcock, 9 years ago

Resolution: wontfix
Status: newclosed

I fixed the ones that were about local variables; using constructor parameters with the same names as the members they initialize is a standard idiom in C++ so I won't change those.

Note: See TracTickets for help on using tickets.