Opened 9 years ago

Closed 9 years ago

#9629 closed Bugs (fixed)

is_permutation code for cxx14 is broken

Reported by: dsp@… Owned by: Marshall Clow
Milestone: To Be Determined Component: algorithm
Version: Boost 1.55.0 Severity: Problem
Keywords: Cc:

Description

1) Lines 59/61 refer to some macro "_VSTD" unknown to my compiler (Visual Studio 2012):

diff1_t len1 = _VSTD::distance(first1, last1);

Presumably "_VSTD" should be replaced by "std".

2) Lines 114/115 refer to some unqualified iterator_traits:

typedef typename iterator_traits<_ForwardIterator1>::value_type value1_t;

Presumably a "std::" prefix is missing here.

Change History (3)

comment:1 by Marshall Clow, 9 years ago

Status: newassigned

comment:2 by Marshall Clow, 9 years ago

I have messed this up to a fare-thee-well.

Besides the problems that you've noted, there are _two_ versions of the four iterator calls to is_permutation; one in the cxx11 header and one in the cxx14 header.

And neither of them checks to see if the standard library implements this call.

And there's some weirdness in the git conversion that I have to sort out first.

comment:3 by Marshall Clow, 9 years ago

Resolution: fixed
Status: assignedclosed

Fixed in cf249c090c3021faebbcf5f6cf5574ce258aa7f6

Note: See TracTickets for help on using tickets.