basic_binary_iprimitive::load_binary bug

[anonymous]

boost\archive\basic_binary_iprimitive.hpp, line 163, line 174. Now code:

   if(count != static_cast<std::size_t>(s))
...
       if(count != 1)

Need:

   if(scount != static_cast<std::size_t>(s))
...
       if(scount != 1)

[Marvin Sielenkemper <Marvin.Sielenkemper@…>]

There is another bug in this function that causes the test

  void BoostBinaryWArchiveBug()
  {
    const std::string srcValue("12345");
    std::string dstValue;

    std::wostringstream os;
    boost::archive::binary_woarchive(os) << srcValue;

    std::wistringstream is(os.str());
    boost::archive::binary_wiarchive(is) >> dstValue;

    BOOST_CHECK_EQUAL(srcValue, dstValue);
  }

to fail with the error message

error in "BoostBinaryWArchiveBug": check srcValue == dstValue failed [12345 != 5234]

I found that bug in version 1.33.1, but the problem seems to still be present in 1.34.1. The bug is fixed by changing the memcpy-line from

        std::memcpy(address, &t, s);

to

        std::memcpy(static_cast<char*>(address) + (count - s), &t, s);

[Robert Ramey]

I'll put this in.