Opened 15 years ago

Closed 15 years ago

#976 closed Patches (fixed)

Updating ICU support in Boost.Regex

Reported by: John Maddock Owned by: John Maddock
Milestone: Boost 1.34.1 Component: Building Boost
Version: Boost 1.34.0 Severity: Regression
Keywords: regex Cc: witt@…

Description

Two quick regex patches: A patch for the Jamfile so that ICU libraries are correctly detected on Win32 (the existing Jamfile works but issues a warning 'cos it can't verify that the libraries are available). A second fixes the ICU test case so it builds with VC8. Both are trivial IMO.

Index: build/Jamfile.v2 =================================================================== RCS file: /cvsroot/boost/boost/libs/regex/build/Jamfile.v2,v retrieving revision 1.12 diff -u -r1.12 Jamfile.v2 --- build/Jamfile.v2 17 Feb 2007 12:22:49 -0000 1.12 +++ build/Jamfile.v2 22 May 2007 09:04:27 -0000 @@ -45,6 +45,10 @@

{

gICU_CORE_LIB = icuuc ;

}

+ else if [ GLOB $(dir)/lib : icuuc.* ] + { + gICU_CORE_LIB = icuuc ; + }

else if [ GLOB $(dir)/lib : libicuuc.* ] {

gICU_CORE_LIB = icuuc ;

RCS file: /cvsroot/boost/boost/libs/regex/test/regress/test_icu.cpp,v retrieving revision 1.5 diff -u -r1.5 test_icu.cpp --- test/regress/test_icu.cpp 14 Sep 2005 12:20:08 -0000 1.5 +++ test/regress/test_icu.cpp 22 May 2007 09:04:29 -0000 @@ -39,8 +39,8 @@

{ private:

Seq* container;

  • typedef const typename Seq::value_type value_type; public:

+ typedef const typename Seq::value_type value_type;

typedef Seq container_type; typedef std::output_iterator_tag iterator_category;

Change History (2)

comment:1 by Thomas Witt, 15 years ago

Cc: witt@… added
Milestone: Boost 1.34.1

comment:2 by John Maddock, 15 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.