boost.format vc8/win32 compilation warning

[const@…]

boost/format/alt_sstream_impl.hpp, line 252 generates warning due to 'secure'-ness of vc8 stl implementation

original boost:

                if(0 < prev_size)
                    compat_traits_type::copy(newptr, oldptr, prev_size);

proposed change:

                if(0 < prev_size)
#if defined(_MSC_VER) && (_MSC_VER == 1400)
                    compat_traits_type::_Copy_s(newptr, new_size, oldptr, prev_size);
#else
                    compat_traits_type::copy(newptr, oldptr, prev_size);
#endif

or use BOOST_WORKAROUND macro.

I'm aware that vc8's stl is not officially supported by boost and it's not a problem to patch it after each update locally, but I'd appreciate if I wouldn't have to.

[storangen@…]

Is the ticket about the same warnings as the ones below?

From http://www.boost.org/more/version_history.html

• Microsoft Visual C++ 6.0 (sp5, with and without STLport), 7.0, 7.1, 8.0. Note: Boost does not support the non-standard "Safe" C++ Library shipping with Visual C++ 8.0, which may result in many spurious warnings from Boost headers and other standards-conforming C++ code. To suppress these warnings, define the macro _SCL_SECURE_NO_DEPRECATE.

[const@…]

Yes. But despite vc8's 'safe' library isn't officially supported, I've seen that some other boost libraries support it quite well. Is it a problem to add a simple workaround to boost.format too?

[storangen@…]

But should Boost support such a non standard library? Isn't SCL_SECURE_NO_DEPRECATE the best solution until the safe routines are standardized?

Is this change really wanted in Boost 1.34.1?

/$

[Thomas Witt]

This is not a 1.34.1 boost does not make a concerted effort to support the "Safe" C++ Library in MSVC 8.

[John Maddock]

Warning suppressed in SVN Trunk.