BOOST_HAS_PTHREAD_MUTEXATTR_SETTYPE not defined for Android

[kervala@…]

I'm using boost::recursive_mutex under Android and I noticed they don't work as expected, they are working like standard mutex.

After further investigation, I noticed BOOST_HAS_PTHREAD_MUTEXATTR_SETTYPE and BOOST_PTHREAD_HAS_TIMEDLOCK were not defined for Android because Android NDK don't declare _POSIX_TIMEOUTS neither _XOPEN_SOURCE that are checked in boost. So boost::recursive_mutex are not recursive at all under Android :(

Also pthread_mutex_timedlock signature changed since Android 5.0 (API 21), the version with the const struct is used from API 21 while previous versions were using the same without the const.

from API 3 to 20: int pthread_mutex_timedlock(pthread_mutex_t *mutex, struct timespec* ts);

from API 21: int pthread_mutex_timedlock(pthread_mutex_t*, const struct timespec*) nonnull((1, 2));

I have some patches to fix these issues :)

[kervala@…]

boost::recursive_mutex fix for Android

[Cédric OCHS <kervala@…>]

Fix of the patch

[Cédric OCHS <kervala@…>]

Please ignore the first patch, I forgot to remove a #endif

[Cédric OCHS <kervala@…>]

I'm sorry, I didn't notice pthread_mutex_timedlock wasn't implemented in bionic before Android API 21, although it was defined in oldest ARM headers (a Google bug in this case).

So I updated my patch for a 3rd time :)

[viboes]

Since which version of Android the 3rd patch is valid?

[Cédric OCHS <kervala@…>]

Thanks for your reply :)

It's valid since Android API 3 (Android 1.5).

I checked all pthread.h header from all Android versions supported by NDK.

[Niall Douglas]

Just for the record, I don't think Boost should support Android before v2. But thanks for the patch, this stuff is exactly why my client funded getting a regular CI going for Android.

[Cédric OCHS <kervala@…>]

You're welcome :)

[viboes]

@Niall: if V2 is the minimal version, could this restriction be encoded on the config.hpp file.

[viboes]

You should create a ticket and a patch for Boost Config (boost/config/posix_features.hpp).

I will fix this soon.

[viboes]

​https://github.com/boostorg/thread/commit/c7bb6fa318ddc27cb1ad9497f295db2744c0f069