Opened 8 years ago

Closed 5 years ago

#11142 closed Bugs (fixed)

boost::date_time::period_parser::delimiter_strings setter doesn't set values

Reported by: Laurent DORE <laurent.dore@…> Owned by: James E. King, III
Milestone: Boost 1.67.0 Component: date_time
Version: Boost 1.57.0 Severity: Problem
Keywords: Cc:

Description

The current code for boost::date_time::period_parser::delimiter_strings setter is: 

    void delimiter_strings(const string_type& ,
                           const string_type& ,
                           const string_type& ,
                           const string_type& )
    {
      m_period_separator;
      m_period_start_delimeter;
      m_open_range_end_delimeter;
      m_closed_range_end_delimeter;
    }

Up to Boost 1.51, a build with clang caused a warning with the -Wunused-parameter option.

The latest change in 7b1b5aa452a9c7cc34230c99ac748a542cc23749 does not address the setter behavior, but removes the warning.

The code should probably be: 

    void delimiter_strings(const string_type& separator,
                           const string_type& start_delim,
                           const string_type& open_end_delim,
                           const string_type& closed_end_delim)
    {
      m_period_separator = separator;
      m_period_start_delimeter = start_delim;
      m_open_range_end_delimeter = open_end_delim;
      m_closed_range_end_delimeter = closed_end_delim;
    }

Change History (4)

comment:1 by James E. King, III, 5 years ago

Owner: changed from az_sw_dude to James E. King, III
Status: new → assigned

comment:3 by James E. King, III, 5 years ago

Milestone: To Be Determined → Boost 1.67.0

comment:4 by James E. King, III, 5 years ago

Resolution: → fixed
Status: assigned → closed

Fix merged to master; resolved.

Note: See TracTickets for help on using tickets.