Opened 6 years ago
Closed 5 years ago
#12323 closed Bugs (fixed)
windows - boost/thread/win32/mfc_thread_init.hpp has wrong signature for _pRawDllMainOrig
| Reported by: | Owned by: | viboes | |
|---|---|---|---|
| Milestone: | Boost 1.66.0 | Component: | thread |
| Version: | Boost 1.61.0 | Severity: | Problem |
| Keywords: | MFC | Cc: |
Description
Signature should be
extern "C" declspec(selectany) BOOL (WINAPI * const _pRawDllMainOrig)(HINSTANCE, DWORD, LPVOID)
and this would match the definition of ExtRawDllMain and the one in <afxdllx.h>
extern "C" BOOL (WINAPI* const _pRawDllMain)(HINSTANCE, DWORD, LPVOID) = &ExtRawDllMain;
Change History (6)
comment:1 by , 6 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 6 years ago
comment:3 by , 5 years ago
| Summary: | boost/thread/win32/mfc_thread_init.hpp has wrong signature for _pRawDllMainOrig → windows - boost/thread/win32/mfc_thread_init.hpp has wrong signature for _pRawDllMainOrig |
|---|
comment:5 by , 5 years ago
| Milestone: | To Be Determined → Boost 1.66.0 |
|---|
Thanks for your collaboration Andrey.
Merged
https://github.com/boostorg/thread/commit/d7010f9924c3928c253a40f5293aaa67a92eaea6
comment:6 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
I'm unable to test on Windows.
Please, could you provide a patch or a github PR?