windows - static threads library is incompatible with MSVC 2017 RC

[z7z7z@…]

Microsoft Visual C++ 2017 RC

While being linked statically with threads library, the EXE exits with the code 255 right after the start.

The problem is because of _PVFV/_PIFV function type mixup in /boost/libs/thread/src/win32/tss_pe.cpp - the on_tls_prepare() is expected to return zero, but it does not initialize the return value.

Seems that after the refactoring of CRT in VC2017 this inconsistency have become critical.

The fix proposed is in the attached version of tss_pe.cpp .

[z7z7z@…]

Fixed tss_pe.cpp

[viboes]

Please, could you provide a patch or even better a github PR?

[anonymous]

Sorry, I dont't use git, so don't do PRs.

The diff of changes proposed is here: ​http://pastebin.com/USCA1FN3

The idea is that seems we can't actually generalize that all callbacks are non-returning or that all callbacks are int-returning. We have to differentiate between _I and _V versions.

Note that the fix was not tested on any other VS version.

[frank.richter@…]

FWIW, looking through some older MSVC CRT sources, back to MSVC 8 the CRT$XI arrays were declared as having int functions - albeit inconsistently, in some places they were treated as void functions. Anyway, perhaps consider extending the change to _MSC_VER >= 1400.

[viboes]

Could someone having access to Windows and git apply the patch and provide a PR on git?

[Andrey Semashev]

See ​https://github.com/boostorg/thread/pull/131.

[viboes]

​https://github.com/boostorg/thread/commit/584b9c2d2963c7ed2f40d0964b24a6807ce0fe74

[viboes]

​https://github.com/boostorg/thread/commit/739f8eeb81d74f1a559d8a075985a3f6e8d7b48b