Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1305 closed Patches (fixed)

Patch to improve support for the CodeGear (Borland) 5.9.2 compiler

Reported by: Nicola Musatti Owned by: Nicola Musatti
Milestone: To Be Determined Component: parameter
Version: Boost Development Trunk Severity: Problem
Keywords: Cc:

Description

The attached patches improve support for the latest CodeGear (Borland) compiler.

Attachments (2)

parameter_boost071007.diff (2.6 KB ) - added by Nicola Musatti 15 years ago.
parameter_libs071007.diff (1.5 KB ) - added by Nicola Musatti 15 years ago.

Download all attachments as: .zip

Change History (7)

by Nicola Musatti, 15 years ago

Attachment: parameter_boost071007.diff added

by Nicola Musatti, 15 years ago

Attachment: parameter_libs071007.diff added

comment:1 by Nicola Musatti, 15 years ago

Owner: changed from Daniel Wallin to Nicola Musatti

comment:2 by Nicola Musatti, 15 years ago

Resolution: fixed
Status: newclosed

Applied

comment:3 by Dave Abrahams, 15 years ago

Resolution: fixed
Status: closedreopened

Nicola,

I'm not sure this is really the right patch. Shouldn't Borland have BOOST_NO_SFINAE set? Please feel free to close the ticket again if not.

comment:4 by Nicola Musatti, 15 years ago

Resolution: fixed
Status: reopenedclosed

I'm aware that this patch is rather ugly. However bcc 5.9.2 does implement SFINAE, although it still has a few problems with it. I tried both alternatives with 1.34 and unsetting BOOST_NO_SFINAE while adding specific workarounds here and there was the combination that got best regression results.

I expect this is even more so with 1.35 as many libraries have since adopted SFINAE to tweak their interface. The availability of SFINAE is the single most common reason for tests that pass with 5.9.2, but fail with previous compilers.

comment:5 by Dave Abrahams, 15 years ago

OK, then if you can find the time, I would prefer then to have another configuration macro (parameter-library-specific if no other libs need it) for this purpose. Code repetition is evil, even PP code.

Note: See TracTickets for help on using tickets.