Boost test can't compare classes which have begin and end but not const_iterator

[marc@…]

The following code:

struct s
{
	const int *begin() const;
	const int *end() const;
};

bool operator==(s,s);
std::ostream &operator<<(std::ostream &out, s);

BOOST_AUTO_TEST_CASE(foo)
{
	s s1;
	s s2;
	BOOST_TEST(s1==s2);
}

When compiled in C++14 mode by gcc or clang, fails because s does not contain member types const_iterator and value_type. This works in C++03 mode, and it worked with boost 1.64.

The attached patch fixes the issue.

[Raffi Enficiaud]

Thanks for the report and the patch, will apply for 1.66. A couple of questions:

• when you say "fails because s does not contain member types ...", does it mean compilation failure or test failure?
• in 1.65, the behaviour changed to check only for the existence of begin/end, while up to 1.64, it was required to have also value_type and const_iterator (as well as size). In your case, that would mean that your class will switch to the collection comparison, while you are providing operator== and I guess you expect that this operator will be used. What is your suggestion?

As a workaround, does this

BOOST_TEST((s1==s2));

work as you expect?

[marc@…]

1. I mean compilation failure.

2. I would prefer doing collection comparison for the better test failure messages, but it's fine if it uses the user-provided equality operator.

The workaround does work.

[Raffi Enficiaud]

Merged to branch topic/13181-collection-compare-missing-typename, but tests are failing, I will check

[Raffi Enficiaud]

Building now

[Raffi Enficiaud]

In master