[program_options] Second (and subsequent) lines in tabbed text not aligned correctly

[anonymous]

When using the tab character to set an alignment for text output, the second (and subsequent) lines are not displayed at the correct position.

It appears that the number of characters between the newline (\n) and tab (\t) are not accounted for.

Example:

    boost::program_options::options_description options("Options");
    options.add_options()
        ("help", "help text")
        ("list",
         "a list:\n      \t"
             "item1, item2, item3, item4, item5, item6, item7, item8, item9, "
             "item10, item11, item12, item13, item14, item15, item16, item17, item18")
    ;

    std::cout << options << std::endl;

[s.ochsenknecht@…]

testcase

[s.ochsenknecht@…]

I cannot reproduce this with current trunk. I think the behaviour is correct. I get following output of the mentioned testcase:

  --list arg            a list:
                          item1, item2, item3, item4, item5, item6, item7, 
                          item8, item9, item10, item11, item12, item13, item14, 
                          item15, item16, item17, item18

I attached an enhancement for the test cases which checks the user case.

Please comment. Thanks.

[Vladimir Prus]

(In [57515]) Test for \t-alignment of options descriptions.

Fixes #1527. Patch from Sascha Ochsenknecht.

[Vladimir Prus]

Sascha, I have applied the patch, thanks!

BTW, was there a specific reason you changed std::string to just string in a couple of places? Not that it matters much.

[s.ochsenknecht@…]

The source already had a "using namespace std;" and at some places were string's defined without "std::". So, I just wanted the source consistent without any redundancy.

Thanks, Sascha

[Chard]

Hi Volodya,

The original issue is valid and still present.

The responding poster has not actually copied the OP's code exactly.

There should be six spaces between the newline (\n) and tab (\t). The patched test code only uses two. This affects the spacing enough to make it output correctly.

Find attached a patch for the test file (as it appears on the trunk), which does cause the failure, and also a patch with the fix, which is a simple one-liner.

[Chard]

patch for test

[Chard]

patch for #1527

[Sascha Ochsenknecht]

Hi,

I just checked in the patch on trunk. It looks ok for me. I leave the Ticket open until Volodya reviewed it.

Sorry for confusion!

Thanks,

• Sascha

[Vladimir Prus]

Seems ok to me. I'm closing this issue. Thanks for the followup, Chard!