no value given in 'mysql_password ='

[Olaf van der Spek <OlafvdSpek@…>]

Hi,

no value given in 'mysql_password ='

When I put this line in a conf file, I get this error. I think it should just accept this as the empty string.

[s.ochsenknecht@…]

possible patch

[s.ochsenknecht@…]

I attached a patch which allows these empty values in config files. I simply removed the exception and enhanced one test case.

But, I can not survey the impact and possible side effects. And do we really want this behavior? At least the tests seam to work fine.

Please comment.

• Sascha

[Sascha Ochsenknecht]

I applied the patch.

With one small modification. Empty values are ignored and nothing is stored. I think it makes sense since an empty string can not be converted to every possible value type, e.g. integer options.

Cheers

• Sascha

[Sascha Ochsenknecht]

(In [57819]) allow empty values in config file, Fixes #1537

[olafvdspek@…]

I don't think that's a good idea. There's a difference between an empty value and no value.

[Vladimir Prus]

I'd agree. Ignoring bits of config file seems a potentially confusing behaviour.

[Sascha Ochsenknecht]

Ok, another proposal would be to store an empty value for string type values (also for collection of strings) and throwing a validation error for e.g. integer types: "invalid option value "

This is probably better than storing a default constructed value, which could be undefined. Or in other words, what is an empty integer? undefined or invalid (I would prefer invalid -> exception)?

Please comment.

[olafvdspek@…]

Invalid

[Sascha Ochsenknecht]

(In [57829]) store empty values from config file, Fixes #1537