Opened 15 years ago
Closed 12 years ago
#1541 closed Patches (fixed)
[parameter] Patch for missing includes
| Reported by: | Owned by: | Daniel Wallin | |
|---|---|---|---|
| Milestone: | Boost 1.36.0 | Component: | parameter |
| Version: | Boost Development Trunk | Severity: | Problem |
| Keywords: | Cc: | jensseidel@… |
Description
The fix for Ticket #1535 has caused a bunch of regression test failures on Trunk for the Parameter library, due to missing includes.
The attached patch adds some missing includes to the parameter headers, and allows the tests to pass when run manually against VC7.1/8.0/9.0
Attachments (2)
Change History (8)
by , 15 years ago
| Attachment: | parameter.patch added |
|---|
by , 15 years ago
| Attachment: | boost.parameter.diff added |
|---|
comment:1 by , 15 years ago
I added another patch which fixes even more missing include statements.
Since I got also many warnings about missing initialisations in python.hpp I added some zeros together with comments as found in another header file:
boost/parameter/python.hpp:66: warning: deprecated conversion from string constant to 'char*' boost/parameter/python.hpp:66: warning: missing initializer for member '_typeobject::tp_traverse' boost/parameter/python.hpp:66: warning: missing initializer for member '_typeobject::tp_clear' ...
All, except the first warning, are now fixed as well.
Now I get only one complain: boost/parameter/aux_/overloads.hpp:64: error: 'BOOST_PP_ENUM_PARAMS' has not been declared But since this is a private header file this is OK.
comment:2 by , 15 years ago
| Milestone: | To Be Determined → Boost 1.36.0 |
|---|---|
| Owner: | changed from to |
| Severity: | Showstopper → Problem |
| Status: | new → assigned |
To clear the test errors I have applied the first patch. I will leave the second patch alone as it is not critical, the library maintainers should decide what to do with it.
comment:3 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → new |
Oops, didn't want to modify the holder...
comment:4 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Since the parameter library is no longer failing its' tests, I'm guessing that this patch is no longer necessary.
If I'm wrong, please reopen this ticket.
follow-up: 6 comment:5 by , 12 years ago
| Cc: | added |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
Your guess is wrong. The file parameter/aux_/default.hpp is still unpatched and misses a #include <boost/detail/workaround.hpp> but uses BOOST_WORKAROUND. Also one or two other files are unpatched.
Is it really so hard for you to apply a one line patch or to check whether it is still required?
comment:6 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Replying to Jens Seidel <jensseidel@…>:
Your guess is wrong. The file parameter/aux_/default.hpp is still unpatched and misses a #include <boost/detail/workaround.hpp> but uses BOOST_WORKAROUND. Also one or two other files are unpatched.
Oops, I'm wrong. I don't have any longer a copy of the Boost repository (why should I when all patches are ignored?) and used the web frontend. It seems I looked partly in too old revisions.
parameter/aux_/python/invoker_iterate.hpp seems to still miss a include of boost/preprocessor/iteration/iterate.hpp for BOOST_PP_ITERATION_FLAGS but I'm not willing to test it now.
I close this bug again ... (the last sentence of the last comments still applies, though).
Another patch