Boost.Config macros badly added.

[John Maddock]

The two macros:

BOOST_NO_THREADEX and BOOST_NO_GETSYSTEMTIMEASFILETIME, should be named BOOST_HAS_* since they describe non-standard features, and should probably be set in win32.hpp given that these are platform rather than compiler specific?

Changes would effect DateTime and Thread libraries as well as Boost.Config.

There are also no docs or test cases for these.

[Dean Michael Berris]

John/Anthony,

Is this still an issue? Has this already been adressed and if not should this be broken up into smaller issues that can independently be addressed?

[anonymous]

Yes it still appears to be an issue, these macros weren't added correctly to Boost.Config.

I don't see how this can be broken up into smaller issues though sorry...

John.

PS if someone takes this on, they will need to take the changes through into the release branch as well.

[Dean Michael Berris]

I'll see if I can get patches out and tests run to see whether I can take this on. I'll give it some time tomorrow morning (PHT), I'll update as I run into issues or whether I have progress appropriately.

[Marshall Clow]

Dean - are you still going to do this?

Here's what a quick search turns up:

trunk marshall$ grep -r BOOST_NO_THREADEX *
boost/config/compiler/visualc.hpp:#  define BOOST_NO_THREADEX
libs/thread/src/win32/thread.cpp:#ifdef BOOST_NO_THREADEX

trunk marshall$ grep -r BOOST_NO_GETSYSTEMTIMEASFILETIME *
boost/config/compiler/visualc.hpp:#  define BOOST_NO_GETSYSTEMTIMEASFILETIME
boost/date_time/filetime_functions.hpp:#elif defined(BOOST_NO_GETSYSTEMTIMEASFILETIME)

If you don't have time, I can probably take care of this.

[Dean Michael Berris]

Nope, sorry about that -- please go ahead and take this one on. I shall punt this to you. :)

[Marshall Clow]

(In [71533]) Renamed BOOST_NO_THREADEX -> BOOST_HAS_THREADEX and BOOST_NO_GETSYSTEMTIMEASFILETIME --> BOOST_HAS_GETSYSTEMTIMEASFILETIME - Refs #1988

[Marshall Clow]

(In [71676]) Merge fixes to release; Fixes #1988