Macros conflict: BOOST_HAS_FTIME and BOOST_NO_GETSYSTEMTIMEASFILETIME

[Andrey Semashev]

There are two macros related to the WinAPI FILETIME-related functions: BOOST_HAS_FTIME and BOOST_NO_GETSYSTEMTIMEASFILETIME. The first one is documented as the one that is defined if the GetSystemTimeAsFileTime API is available, whereas the second one is defined when it's not (while other functions and the FILETIME type itself are available). On Windows Mobile it is possible to get both these macros defined, which is quite contradictory to the documentation.

I believe, docs and tests should be corrected so that BOOST_HAS_FTIME is defined if the FILETIME type is available, and BOOST_NO_GETSYSTEMTIMEASFILETIME is only defined when the GetSystemTimeAsFileTime function is not available. A quick search shows that these macros are only used in Boost.DateTime and in the described meaning.

[John Maddock]

Will fix: but when we're not in a run-up to release.

[Marshall Clow]

How about now? ;-)

[John Maddock]

(In [73058]) Document BOOST_HAS_GETSYSTEMTIMEASFILETIME, add test case, and change test for BOOST_HAS_FTIME. Refs #2881.

[John Maddock]

Fixed in Boost.Config Trunk, but.... note that DateTime's use of these macros seems to be in a mess, and frankly BOOST_HAS_GETSYSTEMTIMEASFILETIME could be probably be removed altogether. Reassigning.