#2963 closed Bugs (fixed)
Inspect tool fails when no errors are found
| Reported by: | Jeremiah Willcock | Owned by: | René Rivera |
|---|---|---|---|
| Milestone: | Boost 1.40.0 | Component: | inspection script |
| Version: | Boost 1.38.0 | Severity: | Problem |
| Keywords: | Cc: |
Description
The Boost inspection program crashes (on OS X, with a null pointer dereference) when run on a directory containing no issues. In particular, line 453 (the first line of the body of worst_offenders_count()) of inspect.cpp (in r52517) accesses msgs.begin(), which is invalid when msgs is empty, leading to a segmentation fault.
Attachments (1)
Change History (7)
by , 14 years ago
| Attachment: | inspect.patch added |
|---|
comment:1 by , 14 years ago
I attached a patch to fix the problem. I just changed the code such that worst_offenders_count() just returns when there are no problems found.
comment:2 by , 14 years ago
| Owner: | changed from to |
|---|
comment:3 by , 13 years ago
| Milestone: | Boost 1.39.0 → Boost 1.40.0 |
|---|
I can commit the patch I attached earlier if you want.
comment:4 by , 13 years ago
The patch looks fine to me, you should just go ahead with it. Inspect doesn't really have a maintainer, so you shouldn't wait for permission. If you want a code review the best place to ask is the development list.
comment:6 by , 13 years ago
(In [53049]) Merge inspect fix for when there are no errors.
Merged revisions 52995 via svnmerge from https://svn.boost.org/svn/boost/trunk
........
r52995 | jewillco | 2009-05-14 15:50:56 +0100 (Thu, 14 May 2009) | 1 line
Fixes #2963
........
Patch to fix bug.