collect_unrecognized cannot find unrecognized options from parse_config_file

[Rhys Ulerich <rhys.ulerich@…>]

program_options::collect_unrecognized does not properly collect unregistered options parsed via parse_config_file when parse_config_file is set to accept unregistered options.

Test case attached as test.cpp.

Compare the number of options that have unregistered == true vs the number of elements in recognized. I expect that the number of unregistered options is identical to the number of unrecognized options collected based upon the documentation.

It looks like parse_config_file fails to set basic_option<charT>.original_tokens correctly, and collect_unrecognized seems to rely on the original_tokens to do its job. The trouble involves boost/program_options/detail/parsers.hpp:135 where the std::copy call is a NOP but should not be.

[Rhys Ulerich <rhys.ulerich@…>]

Recreate demonstrating the problem and showing original_tokens being incorrect

[Vladimir Prus]

In trunk, your test program produces the following output:

Unregistered options parsed...
unknown_option: unknown_option something_unknown

Unrecognized options collected...
unknown_option
something_unknown

and the exit code is 0. IIRC, Sascha has modified config file parser to set original_tokens.

So, shall I close this as fixed, or there's something else?

Thanks, Volodya

[Sascha Ochsenknecht]

Yes, I checked in something. I think this is a duplicate to #2727.

Cheers, Sascha

[Rhys Ulerich <rhys.ulerich@…>]

Sorry guys for filing the dup.