boost::program_options::value_semantic missing 's' at the end

[anonymous]

I am not a native english speaker, but isn't value_semantic missing 's' at the end?

[Vladimir Prus]

Thanks for the report. It is missing 's' indeed ('semantic' is adjective, 'semantics' is noun). However, I suspect changing it at this point will break source and binary compatibility, and therefore we're stuck with this naming forever.

[anonymous]

Replying to vladimir_prus:

Thanks for the report. It is missing 's' indeed ('semantic' is adjective, 'semantics' is noun). However, I suspect changing it at this point will break source and binary compatibility, and therefore we're stuck with this naming forever.

You could provide the necessary typedefs

[Vladimir Prus]

That would still break ABI, I believe. Am I wrong?

[anonymous]

Replying to vladimir_prus:

That would still break ABI, I believe. Am I wrong?

typedef value_semantic value_semantics;

Note the order.

I'm not sure that Boost.ProgramOptions could/should provide any ABI compatibility given that Boost as a whole doesn't provide such.

[anonymous]

Usage of the 'value semantic' phrase should be fixed in the docs regardless of the class name.

[Marshall Clow]

Is there a specific example in the docs that you think should be changed? I've just looked through them and it seems that "value_semantic" (without the 's') is used everywhere except in one case, where it is referring to one or more objects, and so the 's' on the end seems appropriate.

[Marshall Clow]

Since no one has responded, I am closing this ticket. If anyone has specific bugs in the docs, please re-open the ticket with pointers.