[iostreams]write.hpp:write_device_impl<ostream_tag> tries access non-member f

[cppljevans@…]

In the boost/iostreams/write.hpp file, in template specialization:

struct write_device_impl<ostream_tag>

the line:

return !traits_type::eq_int_type( t.rdbuf()->s.sputc(),

should be changed to:

return !traits_type::eq_int_type( t.rdbuf()->sputc(c),

because a streambuf has no s member and the proposed changed reflects what's done elsewhere in the same file.

[Steven Watanabe]

It disturbs me that the tests don't catch this. Do you have a small test case that fails because of this?

[cppljevans@…]

demo of bug

[cppljevans@…]

file #included by previous attachment

[cppljevans@…]

simpler bug demo

[Daniel James]

(In [60228]) Fix write_device_impl<ostream_tag>

And enchance the newline tests so that they test it. Refs #3839

[Daniel James]

I've added a test to newline_tests, but it would be better if we had some more direct tests for write.hpp.

[Daniel James]

(In [60666]) Merge iostreams.

• Fix write_device_impl<ostream_tag>. Fixes #3839
• Fix error checks after calling SetFilePointer. Fixes #3953
• Gzip filter shouldn't require its source to be peekable. Fixes #3723.
• In position_to_offset, only cast to stream_offset after calculating _Myoff. Fixes #3969.
• ptrdiff_t is in std. Fixes #2505.