Opened 13 years ago

Closed 13 years ago

#3953 closed Bugs (fixed)

[boost][iostreams] mapped_file bug on Win32?

Reported by: Erik Nelson <erik.l.nelson@…> Owned by: Daniel James
Milestone: Boost 1.43.0 Component: iostreams
Version: Boost 1.42.0 Severity: Problem
Keywords: Cc:

Description

error checking may be incorrect... see discussion at

​http://comments.gmane.org/gmane.comp.lib.boost.devel/199777

it looks to me like eg's solution (see the thread) would work

Attachments (2)

mapped_file_test.patch​ (1.1 KB ) - added by egoots@… 13 years ago.
Test added which triggers the described failure
mapped_file.patch​ (849 bytes ) - added by egoots@… 13 years ago.
fix to mapped_file.cpp which fixes this error

Download all attachments as: .zip

Change History (7)

by egoots@…, 13 years ago

Attachment: mapped_file_test.patch​ added

Test added which triggers the described failure

by egoots@…, 13 years ago

Attachment: mapped_file.patch​ added

fix to mapped_file.cpp which fixes this error

comment:1 by egoots@…, 13 years ago

Note; The above patches were made against the 1.42.0 sources

comment:2 by anonymous, 13 years ago

Version: Boost 1.41.0 → Boost 1.42.0

comment:3 by Daniel James, 13 years ago

(In [60281]) Fix error checks after calling SetFilePointer. Refs #3953

Thanks to Eg. Especially for writing a test.

comment:4 by Daniel James, 13 years ago

Owner: changed from Jonathan Turkanis to Daniel James
Status: new → assigned

comment:5 by Daniel James, 13 years ago

Resolution: → fixed
Status: assigned → closed

(In [60666]) Merge iostreams.

  • Fix write_device_impl<ostream_tag>. Fixes #3839
  • Fix error checks after calling SetFilePointer. Fixes #3953
  • Gzip filter shouldn't require its source to be peekable. Fixes #3723.
  • In position_to_offset, only cast to stream_offset after calculating _Myoff. Fixes #3969.
  • ptrdiff_t is in std. Fixes #2505.
Note: See TracTickets for help on using tickets.