[PATCH] Fix for warning: enumeral and non-enumeral type in conditional expression

[Lénaïc Huard <lhuard@…>]

Hello,

When compiling some programs using boost.interprocess with gcc, we get a bunch of warning messages like:

include/boost/interprocess/mem_algo/rbtree_best_fit.hpp:323: warning: enumeral and non-enumeral type in conditional expression

The attached patch aims at fixing those warnings.

BRgds, Lénaïc.

[Lénaïc Huard <lhuard@…>]

Patch fixing the warnings: enumeral and non-enumeral type in conditional expression

[Ion Gaztañaga]

Fixed for Boost 1.45 in release branch

[visionofarun@…]

Hi,

I'm reopening the ticket. This ticket appears in Boost 1.45.0 release notes. But seems like its not fixed yet. There are still warning messages with "g++ -W".

#include <boost/interprocess/managed_shared_memory.hpp>
int main()
{
   boost::interprocess::managed_shared_memory *mem;
   return 0;
}

g++ -c -W -fvisibility=hidden -g -Wall  1.cpp -o 1 -I/usr/local/include/boost-1.45.0/
In file included from /usr/local/include/boost-1.45.0/boost/interprocess/detail/managed_memory_impl.hpp:22,
                 from /usr/local/include/boost-1.45.0/boost/interprocess/managed_shared_memory.hpp:21,
                 from 1.cpp:1:
/usr/local/include/boost-1.45.0/boost/interprocess/mem_algo/rbtree_best_fit.hpp:321: warning: enumeral and non-enumeral type in conditional expression
1.cpp: In function 'int main()':
1.cpp:5: warning: unused variable 'mem'

[visionofarun@…]

Hi,

Sorry for posting above.

I'm reopening the ticket. This ticket appears in Boost 1.45.0 release notes. But seems like its not fixed yet. There are still warning messages with "g++ -W".

#include <boost/interprocess/managed_shared_memory.hpp>
int main()
{
   boost::interprocess::managed_shared_memory *mem;
   return 0;
}

g++ -c -W -fvisibility=hidden -g -Wall  1.cpp -o 1 -I/usr/local/include/boost-1.45.0/
In file included from /usr/local/include/boost-1.45.0/boost/interprocess/detail/managed_memory_impl.hpp:22,
                 from /usr/local/include/boost-1.45.0/boost/interprocess/managed_shared_memory.hpp:21,
                 from 1.cpp:1:
/usr/local/include/boost-1.45.0/boost/interprocess/mem_algo/rbtree_best_fit.hpp:321: warning: enumeral and non-enumeral type in conditional expression
1.cpp: In function 'int main()':
1.cpp:5: warning: unused variable 'mem'

[Marshall Clow]

Here's a patch that silences this warning.

[Ion Gaztañaga]

Fixed in Boost 1.47

[anonymous]

i have installed Boost 1.47 right in this moment and it seems like this warning is still persistent...

[Lénaïc Huard <lhuard@…>]

Indeed, I confirm that the warning is still present with Boost 1.47.

The clean way to fix it is definitely to replace all the enums in metafunctions by the usage of BOOST_STATIC_CONSTANT as recommended in the Coding Guidelines for Integral Constant Expressions page and as I proposed in ​boost_interprocess_2.patch.

But as far as I can see, my patch has still not been applied in Boost 1.47.

Ex: ​type_traits.hpp of Boost 1.47

There are still enums whereas I replaced them by BOOST_STATIC_CONSTANT in ​boost_interprocess_2.patch.

[Lénaïc Huard <lhuard@…>]

As mentioned above, the warning is still present. The provided patch has not been applied.

[anonymous]

this is an incredibly, massively annoying bug.

[Ion Gaztañaga]

Fixed in trunk, replaced all enum uses with static const values.