Opened 12 years ago

Closed 12 years ago

#4459 closed Patches (fixed)

[Optional] Trunk build broken as of 20100721

Reported by: ramon.casellas@… Owned by: Fernando Cacciola
Milestone: Boost 1.44.0 Component: optional
Version: Boost 1.44.0 Severity: Showstopper
Keywords: Cc:

Description

May be related to some optional changes or lack of include between graph/Property Tree/XML/GraphML:

In file included from ./boost/property_tree/stream_translator.hpp:17,

from ./boost/property_tree/ptree.hpp:17, from ./boost/property_tree/detail/file_parser_error.hpp:13, from ./boost/property_tree/detail/xml_parser_error.hpp:13, from ./boost/property_tree/detail/xml_parser_utils.hpp:14, from ./boost/graph/graphml.hpp:26, from libs/graph/src/graphml.cpp:17:

./boost/optional/optional_io.hpp: In function ‘std::basic_istream<_CharT, _Traits>& boost::operator>>(std::basic_istream<_CharT, _Traits>&, boost::optional<T>&)’: ./boost/optional/optional_io.hpp:77: error: ‘ios’ has not been declared ./boost/optional/optional_io.hpp:82: error: ‘ios’ has not been declared

Debian GNU/Linux 5.0 2.6.26-2-686 #1 SMP gcc version 4.3.2 (Debian 4.3.2-1.1)

Thanks in advance

R.

Change History (7)

comment:1 by Jeremiah Willcock, 12 years ago

Component: graphoptional
Owner: changed from Andrew Sutton to Fernando Cacciola

Even if it a missing include in BGL that triggered the problem, Boost.Optional is supposed to have all of the necessary includes for its own functions to work.

comment:2 by anonymous, 12 years ago

The fix seems trivial and related to optional changes:

Index: boost/optional/optional_io.hpp
===================================================================
--- boost/optional/optional_io.hpp      (revision 64257)
+++ boost/optional/optional_io.hpp      (working copy)
@@ -74,12 +74,12 @@
     else
     {
       if ( d != '-')
-        in.setstate( ios::failbit );
+        in.setstate( std::ios::failbit );

       d = in.get();

       if ( d != '-')
-        in.setstate( ios::failbit );
+        in.setstate( std::ios::failbit );

       v = optional<T>() ;
     }

comment:3 by anonymous, 12 years ago

Thanks, patch committed in r64342.

comment:4 by Fernando Cacciola, 12 years ago

Thank you for the patch! :)

comment:5 by Vicente Botet <vicente.botet@…>, 12 years ago

Type: BugsPatches

comment:6 by Jeremiah Willcock, 12 years ago

Summary: [BGL] Trunk build broken as of 20100721[Optional] Trunk build broken as of 20100721

comment:7 by Andrey Semashev, 12 years ago

Resolution: fixed
Status: newclosed

Fixed in [67183].

Note: See TracTickets for help on using tickets.