Opened 12 years ago

Closed 12 years ago

#4916 closed Patches (fixed)

regression.py: wrong argument in calls to command_cleanup()

Reported by: Jim Bell <jim@…> Owned by: René Rivera
Milestone: Boost 1.46.0 Component: Regression Testing USE GITHUB
Version: Boost 1.45.0 Severity: Problem
Keywords: regression.py command_cleanup Cc:

Description

regression.py makes three calls to self.command_cleanup(), two as such: self.command_cleanup( [ 'bin' ] )

These calls don't have the intended effect, as [ 'bin' ] passed becomes (['bin'],) as command_cleanup's args, and 

    if 'bin' in args:

fails.

Patch to fix attached.

Attachments (1)

regr_cleanup.patch​ (816 bytes ) - added by Jim Bell <jim@…> 12 years ago.

Download all attachments as: .zip

Change History (4)

by Jim Bell <jim@…>, 12 years ago

Attachment: regr_cleanup.patch​ added

comment:1 by Jim Bell <jim@…>, 12 years ago

The symptom-centric description: regression testing with '--have-source' or '--force-update' should clean up the binaries and do a full run, but instead act the same as '--incremental'.

comment:2 by Vicente Botet <vicente.botet@…>, 12 years ago

Type: Bugs → Patches

comment:3 by Steven Watanabe, 12 years ago

Resolution: → fixed
Status: new → closed

(In [71101]) Fix bug that was preventing the results directory from getting cleaned up when run.py was invoked with --force-update. Fixes #4916.

Note: See TracTickets for help on using tickets.