Opened 12 years ago

Closed 11 years ago

#5145 closed Patches (fixed)

Fixed warning: use of logical && with constant operand; switch to bitwise & or remove constant [-Wconstant-logical-operand]

Reported by: vvavrychuk@… Owned by: Andy Tompkins
Milestone: To Be Determined Component: uuid
Version: Boost 1.47.0 Severity: Problem
Keywords: Cc:

Description

Fixed warning: use of logical && with constant operand; switch to bitwise & or remove constant [-Wconstant-logical-operand]

Attachments (1)

0002-Fixed-warning-use-of-logical-with-constant-operand-s.patch​ (1.1 KB ) - added by anonymous 12 years ago.

Download all attachments as: .zip

Change History (5)

by anonymous, 12 years ago

Attachment: 0002-Fixed-warning-use-of-logical-with-constant-operand-s.patch​ added

comment:1 by Steven Watanabe, 12 years ago

Owner: changed from Dave Abrahams to Andy Tompkins

comment:2 by Marshall Clow, 12 years ago

Applying this patch causes two of the tests to fail (not surprisingly, since it changes the string representation when outputting as wide chars): 

testing.capture-output ../../../bin.v2/libs/uuid/test/test_name_generator.test/clang-darwin-4.2.1/debug/test_name_generator.run
====== BEGIN OUTPUT ======
test_name_generator.cpp(32): test 'u == wcorrect' failed in function 'int main(int, char **)': 'c315270b-a466-5872-aca4-9626cec0f4be' != 'b9506613-2c04-512d-b8fe-bf8d0ba1b271'
test_name_generator.cpp(40): test 'u == wcorrect' failed in function 'int main(int, char **)': 'c315270b-a466-5872-aca4-9626cec0f4be' != 'b9506613-2c04-512d-b8fe-bf8d0ba1b271'
2 errors detected.

EXIT STATUS: 1
====== END OUTPUT ======

The test needs to be adjusted, too. ;-)

comment:3 by Marshall Clow, 12 years ago

(In [68866]) Fix bug in wide output; Refs #5145

comment:4 by Andy Tompkins, 11 years ago

Resolution: → fixed
Status: new → closed
Version: Boost Development Trunk → Boost 1.47.0
Note: See TracTickets for help on using tickets.