quaternion/octonion pow() not working

[Eduardo de Mattos Kalinowski <eduardo@…>]

The pow() functions for quaternions/octonions do not work as they call quaternion<T>(1) instead of quaternion<T>(T(1)).

The attached patches fixes this.

[Eduardo de Mattos Kalinowski <eduardo@…>]

Patch for quaternion.hpp

[Eduardo de Mattos Kalinowski <eduardo@…>]

Patch for octonion.hpp

[John Maddock]

Works for me - what compiler are you using, and do you have a test case please?

Note that quaternion<T>(1) and quaternion<T>(T(1)) should be exactly equivalent as in the former case the argument will be promoted to T anyway.

[Eduardo de Mattos Kalinowski <eduardo@…>]

g++ 4.5.2

For simple types it works, but if there are multiple levels of indirection, it does not. The attached example shows that. A quaternion<Wrapper<int> > works, a quaternion<Wrapper<Wrapper<int> > > does not.

Of course that example is somewhat silly, but I stumbled across this in a case where I do have more than one level of indirection - and not of the same class, naturally.

[Eduardo de Mattos Kalinowski <eduardo@…>]

Test showing multiple levels of indirection

[John Maddock]

(In [70569]) Cast arguments to quaternion/octonion constructors so they still work when there's no implicit conversion available. Fixes #5369.