The warning stack is not maintained

[Tsukasa Kusakabe <kusakabe@…>]

Problem

When "#include" is executed for the following file, the warning stack is destroyed. The cause is a misuse of "#pragma warning(default: warning-number-list)".

File list

• boost/test/utils/nullstream.hpp
• boost/test/utils/iterator/ifstream_line_iterator.hpp

Impact

When the VisualStudio user uses a specific header, a part of a necessary warning is not displayed.

Reproduction code

#include <boost/config.hpp>
#pragma warning(error: 4193)

//boost/test/utils/nullstream.hpp
#pragma warning(pop) // => warning C4193
#include <boost/test/utils/nullstream.hpp>
#pragma warning(pop) // !!! There is not warning. !!!

//boost/test/utils/iterator/ifstream_line_iterator.hpp
#pragma warning(pop) // => warning C4193
#include <boost/test/utils/iterator/ifstream_line_iterator.hpp>
#pragma warning(pop) // !!! There is not warning. !!!

int main() {
  return 0;
}

Patch

boost/test/utils/iterator/ifstream_line_iterator.hpp

@@ -86 +86 @@
 };
 
 #ifdef BOOST_MSVC
-# pragma warning(default: 4355)
+# pragma warning(pop)
 #endif
 
 typedef basic_ifstream_line_iterator<char>      ifstream_line_iterator;

boost/test/utils/nullstream.hpp

@@ -85 +85 @@
 };
 
 #ifdef BOOST_MSVC
-# pragma warning(default: 4355)
+# pragma warning(pop)
 #endif
 
 typedef basic_onullstream<char>      onullstream;

Environment

• OS: Windows 7 Professional SP1
• Compiler:

  Microsoft Visual Studio 2010
  Version 10.0.30319.1 RTMRel
  Microsoft .NET Framework
  Version 4.0.30319 RTMRel
  

Comments

Division origin #5577

[Gennadiy Rozental]

(In [75037]) Added missing " # pragma warning(pop) " Fixes #5870