Making switch matching on the result type of a transform

[Pierre Esterie <pesterie@…>]

Hi,

As discussed in the following thread : ​http://lists.boost.org/proto/2011/08/0559.php

I made a patch on trunk to implement what was discussed. Please, find in attached file the corresponding patch for code reviewing and discussion.

Best,

Pierre Esterie

[Pierre Esterie <pesterie@…>]

patch_switch

[Eric Niebler]

Looks good. Some feedback. The biggest problem is the lack of changes to the reference docs for switch_ (see libs/proto/doc/reference/matches.xml), the missing new_switch.cpp test file, and the formatting that is inconsistent with the rest of Proto's source code. Note: I use 4-spaces for indenting.

Also, you can remove the specialization of switch_::impl in the primary switch_ template. It's still necessary in the specialization of switch_ for the default transform.

Thanks for your work on this!

[Pierre Esterie <pesterie@…>]

Hi Eric,

I modified the patch, you can find the new one in attached file. Please Let me know if I missed something again.

Thanks by advance ! Best,

Pierre

[Eric Niebler]

Thanks. Committed to trunk in [74513]. I'll keep an eye on the regression results and merge to release if it looks good.

[Eric Niebler]

(In [74534]) merge [74470], [74481], [74513], [74527] from trunk; fixes #4723, #5905