iostreams gzip fails to handle optional extra fields in gzip header

[Travis Abbott <typedef.struct@…>]

When bit 2 (FEXTRA) is set in a gzip header's flags, the iostreams code fails to read the XLEN field before starting to read the extra comment. The code is actually there to do it, but it gets skipped. This means the code goes directly a loop like: while (--xlen != 0) with xlen still set to 0. This results in the rest of the file being slurped in by this comment reading code (or at least until xlen wraps around to 0 again, which could take awhile). I ran into this because many popular file formats in bioinformatics (BAM, tabix) are gzipped and include extra optional fields in their headers.

I've attached an example gzipped file with an optional header, a test program that should demonstrate the problem (against 1.47 and latest svn), as well as a patch that fixes it.

[Travis Abbott <typedef.struct@…>]

gzip file with extra comment in header

[Travis Abbott <typedef.struct@…>]

test case that demonstrates the problem (run ./example sample.txt.gz)

[Travis Abbott <typedef.struct@…>]

patch that fixes the issue (patch -p0 < iostreams-gzip.patch from top level of the repo)

[typedef.struct@…]

Seems like this is still present in 1.48 and current SVN. To be clear, the sample file is not empty. The desired output would be for the test program to read "hello there", but it gets nothing. You can compare to gzip -dc. The supplied patch still works with current SVN.

[typedef.struct@…]

Also worth mentioning is that this worked in 1.40, but when the ability to support multiple compressed objects in 1 gzipped stream was introduced, this bug appeared.

[typedef.struct@…]

second patch adding unit test to prevent future regressions.

[typedef.struct@…]

The test attached in the second patch (iostreams-gzip_hdr_test.patch) will fail with the current code, demonstrating the inability to parse certain types of RFC 1952 compliant gzip headers. Application of the first patch will cause the test to pass.

[Jonathan Turkanis]

I have applied the patches to trunk.

[Daniel James]

(In [77368]) Iostreams: Merge from trunk.

• [74728] Eliminate unit_test_framework and BOOST_MESSAGE.
• [76301] Fixes #5908.
• [76941] Fix typos in comments. Fixes #6530.
• [76973] Remove extra semi-colons, which break with trunk Boost.Test.
• [77174] Fix parameters for filter::close. Fixes #6650.

[Smithc195]

Hi. Only wanted to ask a quick issue. Now i am eaadkebdkckdgfgd