Opened 11 years ago

Closed 10 years ago

#6013 closed Patches (fixed)

endian.hpp header patch to utilize OpenBSD's endian header

Reported by: brad@… Owned by: John Maddock
Milestone: Boost 1.48.0 Component: config
Version: Boost Development Trunk Severity: Problem
Keywords: Cc:

Description

The attached patch for Boost's endian.hpp header is to utilize OpenBSD's endian header.

Attachments (3)

patch-boost_detail_endian_hpp​ (732 bytes ) - added by brad@… 11 years ago.
endian.patch​ (962 bytes ) - added by riz@… 10 years ago.
Updated BSD patch for boost/detail/endian.hpp
boost_endian.diff​ (1000 bytes ) - added by brad@… 10 years ago.
Updated BSD patch for boost/detail/endian.hpp

Download all attachments as: .zip

Change History (18)

by brad@…, 11 years ago

Attachment: patch-boost_detail_endian_hpp​ added

comment:1 by anonymous, 11 years ago

Which Boost library (component) are you using that needs this patch?

comment:2 by brad@…, 11 years ago

The same code that uses this header in the first place.

comment:3 by viboes, 11 years ago

Component: None → asio
Owner: set to chris_kohlhoff

comment:4 by anonymous, 11 years ago

How is this related to asio?

comment:5 by brad@…, 10 years ago

ping.

by riz@…, 10 years ago

Attachment: endian.patch​ added

Updated BSD patch for boost/detail/endian.hpp

comment:6 by riz@…, 10 years ago

I recently tried building something using Boost on NetBSD/arm using boost 1.52, and it failed because it couldn't detect the endianness properly. I see that in the trunk there is testing against ARMEL and ARMEB, but the proper way to fix it is to use sys/endian.h (or, I guess, machine/endian.h under OpenBSD).

The updated patch should be correct for NetBSD, FreeBSD, OpenBSD, and DragonFlyBSD.

comment:7 by brad@…, 10 years ago

That looks good to me.

comment:8 by brad@…, 10 years ago

Any chance of getting a review of the pending patch?

comment:9 by brad@…, 10 years ago

riz:

Actually looking at that diff again there is a mistake in it.

The line.. "+# define BOOST_BYTE_ORDER BYTE_ORDER" should be using _BYTE_ORDER not BYTE_ORDER.

by brad@…, 10 years ago

Attachment: boost_endian.diff​ added

Updated BSD patch for boost/detail/endian.hpp

comment:10 by brad@…, 10 years ago

Here is an updated diff with the issue I mentioned above fixed.

comment:11 by John Maddock, 10 years ago

Owner: changed from chris_kohlhoff to John Maddock

comment:12 by John Maddock, 10 years ago

(In [82996]) Apply BSD patch. Refs #6013.

comment:13 by John Maddock, 10 years ago

Component: asio → config

comment:14 by brad@…, 10 years ago

John, Thank you for commiting this.

comment:15 by John Maddock, 10 years ago

Resolution: → fixed
Status: new → closed

(In [83139]) Merge changes from Trunk. Fixes #6013. Fixes #7151. Fixes #7359. Fixes #7389. Fixes #7452. Fixes #7528. Fixes #7703. Fixes #7841. Fixes #7898. Fixes #7938. Fixes #8048.

Note: See TracTickets for help on using tickets.