range::unique does not forward predicate

[andy@…]

At boost\range\algorithm\unique.hpp:92

/// \overload
template< class ForwardRange, class BinaryPredicate >
inline BOOST_DEDUCED_TYPENAME range_return<ForwardRange, return_begin_found>::type
unique( ForwardRange& rng, BinaryPredicate pred )
{
    BOOST_RANGE_CONCEPT_ASSERT(( ForwardRangeConcept<ForwardRange> ));
    return ::boost::range::unique<return_begin_found>(rng);
}

does not forward pred

[andy@…]

Example of bug

[andy@…]

Bug fix + test expansion to cover

[andy@…]

I also changed the signature of the function accepting a const range&, range/algorithm/unique.hpp:96

inline BOOST_DEDUCED_TYPENAME range_return<const ForwardRange, return_begin_found>::type

That is in line with the other overloads, and I couldn't get the newer tests to work without that.

Additionally, in the unique.cpp tests, the predicate being used was incorrect - it was using std::less and std::greater for comparing equality. I changed them to be using std::equal_to

[Neil Groves]

The proposed changes have been applied to the trunk. Thanks for helping. Please accept my apologies for failing to cover the full overload set.

[andy@…]

No apology necessary! I love the Boost Range library, and am happy to have helped in this small way.