bcp misses some cases and does not create namespace aliases for non-boost namespaces

[Mike Liang <mtliang@…>]

Running all Boost 1.48.0 regressions and comparing between original and bcp'd code shows extra compile errors addressed by the enclosed patch.

Also, the namespace alias option only creates aliases for the boost namespace but omits the top level phoenix namespace. This patch includes adstl and rapidxml even though they don't appear to be affected. The patch also preserves whitespace, which was blindly replaced by spaces in the original code.

[lukester_null@…]

I hope I'm not thread jacking but I'd just like to say this is great - fixes something I was just about to create a ticket for. It was converting:

namespace boost{ namespace phoenix

->

namespace MyBoost { namespace MyBoostphoenix

But missing things like:

BOOST_PHOENIX_DEFINE_EXPRESSION(
    (boost)(phoenix)(do_while)

which ended up as

    (MyBoost)(phoenix)(do_while)

which your patch makes (MyBoost)(MyBoostphoenix)(do_while)

I'm not sure I understand why it prefixes the new top-level namespace on the phoenix namespace at all, though I guess it's intentional?

Regards

Luke.

[Mike Liang <mtliang@…>]

I wondered that too until I found the header files under boost/spirit/home/classic/phoenix .

[lukester_null@…]

Ah right, so the classic phoenix namespace gets renamed because it's not nested inside the boost namespace to avoid any potential clashes, and the new phoenix(es) namespace which are nested in boost get caught in the crossfire... or something.

If so, I wonder if that was the desired effect? Most of the new boost::phoenix namespace declarations I've seen are all on one line so it's presumably possible to catch them.

[Mike Liang <mtliang@…>]

I can see why each namespace declaration is renamed independently of any others, since extra code can show up before the embedded phoenix namespace declaration, and so you don't want to write more complicated patterns in an attempt to catch this situation. This then leads to the forced rename of the embedded phoenix namespace during namespace resolution.

In any case, the patch to catch the other renamed namespaces should make this annoyance go away.

[John Maddock]

Thanks for the patch, currently testing it out.

[John Maddock]

(In [79403]) Apply patch from #7070 to fix namespace renaming. Fixes #7070.