numeric::average gives incorrect result

[james.hirschorn@…]

Apparently boost::numeric::average was incorrectly implemented as numeric::divides.

The following code, computes average(2, 3) = 0.666667:

#include <iostream>
#include <boost/accumulators/numeric/functional.hpp>

int main(int argc, char * argv[])
{
    using namespace boost::numeric;

    auto avg = average(2, 3);

    std::cout << avg << std::endl;
}

[james.hirschorn@…]

patch giving correct average

[james.hirschorn@…]

patch correcting numeric::average

[james.hirschorn@…]

The first attachment was by accident. functional.hpp is the modified source.

[Eric Niebler]

Looks right to me.

[Eric Niebler]

Oops, I see what you mean. Sory 'bout that. I'll have a look.

[Eric Niebler]

(In [85124]) rename average to fdiv, refs #8262

[Eric Niebler]

Fixed on trunk. I'll merge to release after tests have cycled. The function isn't incorrect per se; it's just very, very badly named.

[Eric Niebler]

(In [85424]) merge [85122],[85123],[85124] from trunk to release; fixes #7915, fixes #8850, fixes #8262

[timpie.w@…]

The fix seems incorrect.

typedef typename functional::divides<Left, Right>::result_type result_type;

looks incorrect and I think it should be

typedef typename functional::divides<

typename functional::plus<Left, Right>::result_type, int>::result_type result_type;