Opened 10 years ago

Closed 5 years ago

#8450 closed Bugs (fixed)

Missing casts in c_local_time_adjustor.hpp lead to year 2038 problem

Reported by: raad@… Owned by: James E. King, III
Milestone: Boost 1.67.0 Component: date_time
Version: Boost 1.53.0 Severity: Problem
Keywords: Cc:

Description

The duration_rep_type, hour_type and min_type values are not cast to std::time_t, so if they are 32-bit and std::time_t is 64-bit, std::time_t t2 becomes negative for dates after year 2038 and c_time::localtime throws an exception.

With the casts to std::time_t in the attached patch, no exception is thrown.

Attachments (1)

c_local_time_adjustor.hpp.patch​ (753 bytes ) - added by raad@… 10 years ago.
Patch that fixes the problem

Download all attachments as: .zip

Change History (3)

by raad@…, 10 years ago

Attachment: c_local_time_adjustor.hpp.patch​ added

Patch that fixes the problem

comment:1 by James E. King, III, 5 years ago

Milestone: To Be Determined → Boost 1.67.0
Owner: changed from az_sw_dude to James E. King, III
Status: new → assigned

This was resolved in the fix for #11142:

​https://github.com/boostorg/date_time/commit/18b6ca816067cd143954bfb94f42eb29a1637a45#diff-b30985870682449169eb765b8e032ef1R51

comment:2 by James E. King, III, 5 years ago

Resolution: → fixed
Status: assigned → closed

Fix merged to master; resolved.

Note: See TracTickets for help on using tickets.